Fix incorrect resource placements on certain maps

[ihhub]

close #6393

This change must be thoughtfully tested on many maps to make sure that we don't break anything. The test scope should be done on maps with "bad" resources as well as any normal resources.

[Branikolog]

A miracle is here! :)
Resource is weirdly looking, being rendered over mountains, If it's not possible, to render it under mountains, like it was in the OG, I cannot imagine any better solution here.

[ihhub]

Hi @Branikolog , please test this issue on normal resources being generate on multiple maps as well as the underlying logic for placing them was modified.

[ihhub]

@Branikolog , I also added an error log in case if incorrect resource type would appear on any map. Try to load dozens of maps to see if you get the error message.

[Districh-ru]

Hi, @ihhub, @Branikolog, a couple of months ago I found a bug in "Voyage Home" expansion company, map 2. It has an unknown mine. But OG also has the same bug and it does not lead to a game crush, so I forgot about it :)

Save file: vh2_bad_mine.zip

PS I don't ask to fix in in this PR, just remembered. :)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication

[oleg-derevenetz]

@Districh-ru see #5537 :)

[Districh-ru]

@Districh-ru see #5537 :)

Thanks, I'll add my post with the save file to this issue.

[zenseii]

I've loaded up every single scenario map that comes with the GOG release and every single campaign scenario with DBG_GAME turned on, and searched for the string "contains unknown resource type" in the log file and nothing turned up.

[Districh-ru]

@ihhub, I also have checked all maps I have (it's a standard set from Buka CD) and did not find any unknown resource type.
Also I checked on what maps works your fix: maps 'peasants.mx2' and 'whoam.mp2' has 1 resource under an object. And map 'lostreli.mp2' has 5.

[oleg-derevenetz]

LGTM. Could you please apply the IWYU suggestion? Also do you want to leave the ERROR_LOG? I used the DEBUG_LOG with DBG_GAME and DBG_WARN in similar cases.

[ihhub]

LGTM. Could you please apply the IWYU suggestion? Also do you want to leave the ERROR_LOG? I used the DEBUG_LOG with DBG_GAME and DBG_WARN in similar cases.

Oh, I missed IWYU suggestion again :( I changed logging to DEBUG_LOG.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

0.0% Coverage
0.0% Duplication