Experimental iOS Support #8407
Experimental iOS Support #8407
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,6 +23,8 @@ | |||
| #include <ostream> | |||
| #include <stdexcept> | |||
|
|
|||
| #include <CoreFoundation/CoreFoundation.h> | |||
There was a problem hiding this comment.
CoreFoundation/CoreFoundation.h file not found
| */ | ||
|
|
||
| /* Include the SDL main definition header */ | ||
| #include "SDL_main.h" |
There was a problem hiding this comment.
SDL_main.h file not found
| #define NS_ENUM(_type, _name) enum _name : _type _name; enum _name : _type | ||
| typedef metal::int32_t EnumBackingType; | ||
| #else | ||
| #import <Foundation/Foundation.h> |
There was a problem hiding this comment.
#import is a language extension
| #define NS_ENUM(_type, _name) enum _name : _type _name; enum _name : _type | ||
| typedef metal::int32_t EnumBackingType; | ||
| #else | ||
| #import <Foundation/Foundation.h> |
There was a problem hiding this comment.
Foundation/Foundation.h file not found
| typedef metal::int32_t EnumBackingType; | ||
| #else | ||
| #import <Foundation/Foundation.h> | ||
| typedef NSInteger EnumBackingType; |
There was a problem hiding this comment.
use using instead of typedef
| typedef NSInteger EnumBackingType; | |
| using EnumBackingType = int; |
|
|
||
| #include <simd/simd.h> | ||
|
|
||
| typedef NS_ENUM(EnumBackingType, BufferIndex) |
There was a problem hiding this comment.
all parameters should be named in a function
| typedef NS_ENUM(EnumBackingType, BufferIndex) | |
| typedef NS_ENUM(EnumBackingType /*unused*/, BufferIndex /*unused*/) |
| BufferIndexUniforms = 2 | ||
| }; | ||
|
|
||
| typedef NS_ENUM(EnumBackingType, VertexAttribute) |
There was a problem hiding this comment.
all parameters should be named in a function
| typedef NS_ENUM(EnumBackingType, VertexAttribute) | |
| typedef NS_ENUM(EnumBackingType /*unused*/, VertexAttribute /*unused*/) |
| VertexAttributeTexcoord = 1, | ||
| }; | ||
|
|
||
| typedef NS_ENUM(EnumBackingType, TextureIndex) |
There was a problem hiding this comment.
all parameters should be named in a function
| typedef NS_ENUM(EnumBackingType, TextureIndex) | |
| typedef NS_ENUM(EnumBackingType /*unused*/, TextureIndex /*unused*/) |
| TextureIndexColor = 0, | ||
| }; | ||
|
|
||
| typedef struct |
There was a problem hiding this comment.
use using instead of typedef
| typedef struct | |
| using Uniforms = struct |
| { | ||
| matrix_float4x4 projectionMatrix; | ||
| matrix_float4x4 modelViewMatrix; | ||
| } Uniforms; |
There was a problem hiding this comment.
use using instead of typedef
| } Uniforms; | |
| }; |
| TextureIndexColor = 0, | ||
| }; | ||
|
|
||
| typedef struct |
There was a problem hiding this comment.
constructor does not initialize these fields: projectionMatrix, modelViewMatrix
| @@ -26,6 +26,7 @@ | |||
| #include <fstream> | |||
| #include <memory> | |||
| #include <utility> | |||
| #include <CoreFoundation/CoreFoundation.h> | |||
There was a problem hiding this comment.
CoreFoundation/CoreFoundation.h file not found
|
Hi, @dbratcher. I know you said you were busy and wouldn't have much time to look into. If you ever do, could you please address the build check comments? Thank you! |
Sets up an iOS project and experiments with getting resources to load in the iOS system