Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Vietnamese Translation R.2 #8427

Open
wants to merge 93 commits into
base: master
Choose a base branch
from
Open

Update the Vietnamese Translation R.2 #8427

wants to merge 93 commits into from

Conversation

Nad-SK
Copy link
Contributor

@Nad-SK Nad-SK commented Feb 21, 2024

  • Editor translate
  • Update translation files

Nad-SK and others added 30 commits September 13, 2023 23:06
@Nad-SK
Update Vietnamese Translation P5
be6389a 
Towns name and more
@Nad-SK
Merge branch 'master' into master
baf83c6
@Nad-SK
Merge branch 'master' into master
8297365
@Nad-SK
Merge branch 'master' into master
ae8afe7
@Nad-SK
Update vi.po
a032dd5
@Nad-SK
Update vi.po
286d1f9
@Nad-SK
Merge branch 'master' of https://github.com/Nad-SK/fheroes2
e3a14f2
@Nad-SK
Merge branch 'master' into master
61f9d57
@ihhub
Merge branch 'master' into master
ec76bb3
@Nad-SK
Update vi.po
943549f
@Nad-SK
Merge branch 'master' into master
9b941e9
@Nad-SK
Merge branch 'master' into master
b2a700f
@Nad-SK
Update vi.po
80c87a7
@Nad-SK
Update Vietnamese Translation P6
931abef 
Names and more
@Nad-SK
Merge branch 'master' into master
e3ecf6e
@Nad-SK
Update vi.po
bb9315e
@Nad-SK
Update vi.po
92a18d7
@ihhub
Merge branch 'master' into master
f5f0ddb
@Nad-SK
Merge branch 'master' into master
932654b
@Nad-SK
Merge branch 'master' into master
7825287
@Nad-SK
Update vi.po
83d0e52
@Nad-SK
Update Vietnamese Translation P7
6aeb59f 
P7
@Nad-SK
Merge branch 'master' into master
eaf9e39
@Nad-SK
Update vi.po
669041f
@Nad-SK
Update Vietnamese Translation P8
3163797 
P8
@Nad-SK
Update vi.po
7321209
@Nad-SK
Merge branch 'master' into master
e039d74
@Nad-SK
Merge branch 'master' into master
aca9385
@Nad-SK
Update vi.po
2213003
@Nad-SK
Update vi.po
cd1d81c
zenseii
zenseii requested changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@zenseii zenseii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @Nad-SK. You added many new changes, but you didn't seem to address the comments I made. Please do that and don't add new things to this PR.

files/lang/vi.po Show resolved Hide resolved
@ihhub
Copy link
Owner

ihhub commented Mar 23, 2024

Hi @Nad-SK , please address given comments by @zenseii .

@ihhub ihhub marked this pull request as draft March 31, 2024 07:55
@Nad-SK Nad-SK marked this pull request as ready for review May 6, 2024 15:25
@Nad-SK Nad-SK requested a review from zenseii May 8, 2024 06:48
@Nad-SK
Copy link
Contributor Author

Nad-SK commented May 8, 2024

Hi @Nad-SK , please address given comments by @zenseii .

It's fixed.
I've been so busy these past few months.

@ihhub
Copy link
Owner

ihhub commented May 20, 2024

Hi @Nad-SK , your changes are breaking the compilation. Please take a look at logs which indicate the problem.

@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub marked this pull request as draft May 26, 2024 13:55
@Nad-SK Nad-SK marked this pull request as ready for review June 17, 2024 03:47
@zenseii
Copy link
Collaborator

zenseii commented Jul 6, 2024

Hi, @Nad-SK. Could you please solve the merge conflicts?

@Nad-SK
Copy link
Contributor Author

Nad-SK commented Jul 7, 2024

Hi, @Nad-SK. Could you please solve the merge conflicts?
Is this OK?

@zenseii
Copy link
Collaborator

zenseii commented Jul 7, 2024

Hi, @Nad-SK. Could you please solve the merge conflicts?
Is this OK?

The build checks report an error so something went wrong. Please double check the changes you did in your merge commit f0a6bc4

@Nad-SK
Copy link
Contributor Author

Nad-SK commented Jul 10, 2024

@zenseii , Pls check

@zenseii
Copy link
Collaborator

zenseii commented Jul 10, 2024

Hi, @Nad-SK. There are 181 lines of changes too many in this PR. Please reduce them so that the PR can be reviewed.

@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
@ihhub ihhub modified the milestones: 1.1.2, 1.1.3 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenseii zenseii Awaiting requested review from zenseii

Requested changes must be addressed to merge this pull request.

Assignees

@Nad-SK Nad-SK

Labels
improvement New feature, request or improvement translation Things related to languages and translations
Projects
None yet
Milestone
1.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Nad-SK @zenseii @ihhub @oleg-derevenetz