Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid calculation of "short" object passability #8429

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Fix invalid calculation of "short" object passability #8429

wants to merge 10 commits into from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Feb 24, 2024

relates to #4495

@ihhub ihhub added bug Something doesn't work logic Things related to game logic labels Feb 24, 2024
@ihhub ihhub added this to the 1.1.0 milestone Feb 24, 2024
@ihhub ihhub self-assigned this Feb 24, 2024
github-actions[bot]
github-actions bot reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/maps/maps_tiles_helper.cpp Show resolved Hide resolved
src/fheroes2/maps/maps_tiles.cpp Show resolved Hide resolved
@ihhub ihhub marked this pull request as draft February 24, 2024 16:04
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ihhub ihhub

Labels
bug Something doesn't work logic Things related to game logic
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ihhub