Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend button resizing to include height #8562

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zenseii
Copy link
Collaborator

@zenseii zenseii commented Apr 9, 2024

WIP still need to tune some things.
Note that this animation is just an example, because single-line buttons of this kind won't need resizing in the height.
gifmaker_me (1)

@zenseii zenseii changed the title Add ability to button resize in height too. Extend button resizing to height Apr 9, 2024
@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff translation Things related to languages and translations labels Apr 9, 2024
@zenseii zenseii added this to the 1.1.0 milestone Apr 9, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/gui/ui_button.cpp Show resolved Hide resolved
src/fheroes2/gui/ui_button.cpp Show resolved Hide resolved
src/fheroes2/gui/ui_button.cpp Show resolved Hide resolved
src/fheroes2/gui/ui_button.cpp Show resolved Hide resolved
Remove unnecessary additions to offsets
@zenseii zenseii changed the title Extend button resizing to height Extend button resizing to include height Apr 10, 2024
@ihhub ihhub modified the milestones: 1.1.0, 1.1.1 May 22, 2024
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement translation Things related to languages and translations ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants