-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI should determine best skill when leveling up heroes #8591
Conversation
dc2c0ce
to
67c34db
Compare
67c34db
to
906ceeb
Compare
Hi @idshibanov , please rebase your branch from master to fix GitHub Actions. |
…i-secondary-skills
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @idshibanov , I put several comments here. Could you please take a look at them when you have time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @idshibanov , I left few more small comments here. Would you mind to take a look once you have spare time?
Hello, I've always wanted to ask if Mysticism has any value. It looks like it has pretty many scores in descision making code, but it only gives you something like 4 sp/day at max. This is pretty low, especially for magic heroes who may use 100 sp and more during one battle. If it was me, I've either raised the sp/day ratio, or lowered this skill stratigic value. It's much more interesting to have more competitive skills then junk skills. Also the number of well objects matters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @idshibanov , I left several comments here. Would you mind please to take a look at them?
fb207b6
to
38c5915
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Hi @idshibanov I rebased this PR against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
@idshibanov , thank you so much for this improvement! |
Currently AI just rolls randomly when picking a new secondary skills. This decision should be driven by a value estimation, same as everything else.