Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI should determine best skill when leveling up heroes #8591

Merged
merged 12 commits into from
Jul 29, 2024

Conversation

idshibanov
Copy link
Collaborator

Currently AI just rolls randomly when picking a new secondary skills. This decision should be driven by a value estimation, same as everything else.

@idshibanov idshibanov added improvement New feature, request or improvement AI Artificial intelligence behaviour labels Apr 25, 2024
@idshibanov idshibanov self-assigned this Apr 25, 2024
@ihhub
Copy link
Owner

ihhub commented Apr 30, 2024

Hi @idshibanov , please rebase your branch from master to fix GitHub Actions.

@idshibanov idshibanov requested a review from ihhub May 2, 2024 21:52
@ihhub ihhub added this to the 1.1.1 milestone May 5, 2024
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @idshibanov , I put several comments here. Could you please take a look at them when you have time?

src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world_regions.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world_regions.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world_regions.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world.cpp Outdated Show resolved Hide resolved
@idshibanov idshibanov requested a review from ihhub May 5, 2024 08:18
Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @idshibanov , I left few more small comments here. Would you mind to take a look once you have spare time?

src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
@ihhub ihhub self-requested a review May 6, 2024 04:07
@crypt47
Copy link

crypt47 commented May 6, 2024

Hello, I've always wanted to ask if Mysticism has any value. It looks like it has pretty many scores in descision making code, but it only gives you something like 4 sp/day at max. This is pretty low, especially for magic heroes who may use 100 sp and more during one battle. If it was me, I've either raised the sp/day ratio, or lowered this skill stratigic value. It's much more interesting to have more competitive skills then junk skills. Also the number of well objects matters.

Copy link
Owner

@ihhub ihhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @idshibanov , I left several comments here. Would you mind please to take a look at them?

src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/world/world.h Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
src/fheroes2/ai/normal/ai_normal_hero.cpp Outdated Show resolved Hide resolved
@idshibanov idshibanov requested a review from ihhub June 29, 2024 02:45
@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 7, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/ai/ai_planner.h Outdated Show resolved Hide resolved
@oleg-derevenetz
Copy link
Collaborator

Hi @idshibanov I rebased this PR against master to resolve conflicts after #8986, could you please take a look, just in case?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/fheroes2/ai/ai_planner_hero.cpp Show resolved Hide resolved
src/fheroes2/ai/ai_planner_hero.cpp Show resolved Hide resolved
@ihhub ihhub merged commit ce6aa75 into ihhub:master Jul 29, 2024
20 checks passed
@ihhub
Copy link
Owner

ihhub commented Jul 29, 2024

@idshibanov , thank you so much for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Artificial intelligence behaviour improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants