Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra checks for serialization code #8736

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add extra checks for serialization code #8736

wants to merge 2 commits into from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented May 25, 2024

To make sure that we don't cause excessive memory usage or (almost) infinite loops.

@ihhub
Add extra checks for serialization code
43f8d9b 
To make sure that we don't cause excessive memory usage or (almost) infinite loops.
@ihhub ihhub added improvement New feature, request or improvement logic Things related to game logic labels May 25, 2024
@ihhub ihhub added this to the 1.1.1 milestone May 25, 2024
@ihhub ihhub self-assigned this May 25, 2024
github-actions[bot]
github-actions bot reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/engine/serialize.h Outdated Show resolved Hide resolved
@ihhub ihhub removed the request for review from oleg-derevenetz May 25, 2024 07:04
@ihhub ihhub marked this pull request as draft May 25, 2024 07:04
@ihhub
Copy link
Owner Author

ihhub commented May 25, 2024

Such approach will slow down file reading.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ihhub ihhub

Labels
improvement New feature, request or improvement logic Things related to game logic
Projects
None yet
Milestone
1.1.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ihhub