Make default knowledge value for random hero as 1 #8813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, limit minimum knowledge value to 1 rather than 0. close #8750
ihhub
added
improvement
|
Districh-ru
requested changes
Jun 8, 2024
There was a problem hiding this comment.
Hi, @ihhub.
In this PR we only clamp the "modified" knowledge value, but the base knowledge can still be 0.
We should not allow to enter a value lower than 1 for knowledge in hero edit dialog and in battle only dialog.
fheroes2.2024-06-08.07-06-28-904.1.mp4
Comment on lines
+207
to
+208
| int power{ 0 }; | ||
| int knowledge{ 0 }; |
There was a problem hiding this comment.
Should we also set 1 as the default value for power and knowledge skills then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, limit minimum knowledge value to 1 rather than 0.
close #8750