-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Battle::Unit::CalculateSpellDamage() method to use fheroes2::getSpellDamage() and fheroes2::getMonsterData() functions #8839
Open
Cheerfulbull
wants to merge
17
commits into
ihhub:master
Choose a base branch
from
Cheerfulbull:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 15, 2024
-
Introduce usage of getSpellDamage, thereby removing damage calculation and attacker artefact check.
Configuration menu - View commit details
-
Copy full SHA for f7975af - Browse repository at this point
Copy the full SHA f7975afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b6c034 - Browse repository at this point
Copy the full SHA 0b6c034View commit details -
Configuration menu - View commit details
-
Copy full SHA for 962e59e - Browse repository at this point
Copy the full SHA 962e59eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f695a0 - Browse repository at this point
Copy the full SHA 1f695a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44ec9d3 - Browse repository at this point
Copy the full SHA 44ec9d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbc2f2b - Browse repository at this point
Copy the full SHA cbc2f2bView commit details
Commits on Jun 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e3bf74d - Browse repository at this point
Copy the full SHA e3bf74dView commit details -
Merge pull request #1 from Cheerfulbull/Cheerfulbull-patch-1
Update battle_troop.cpp
Configuration menu - View commit details
-
Copy full SHA for c3e0ccf - Browse repository at this point
Copy the full SHA c3e0ccfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4975fa9 - Browse repository at this point
Copy the full SHA 4975fa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for d75394b - Browse repository at this point
Copy the full SHA d75394bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f4910f - Browse repository at this point
Copy the full SHA 6f4910fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5add5 - Browse repository at this point
Copy the full SHA fa5add5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d921cf - Browse repository at this point
Copy the full SHA 3d921cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 369c937 - Browse repository at this point
Copy the full SHA 369c937View commit details -
Configuration menu - View commit details
-
Copy full SHA for f243c7c - Browse repository at this point
Copy the full SHA f243c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c13d6ed - Browse repository at this point
Copy the full SHA c13d6edView commit details -
Merge pull request #2 from Cheerfulbull/Cheerfulbull-patch-2
Update battle_troop.cpp
Configuration menu - View commit details
-
Copy full SHA for beacc4a - Browse repository at this point
Copy the full SHA beacc4aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.