Implement special victory and loss conditions for heroes and towns

[Districh-ru]

close #8717

This PR adds ability to set in Editor the next special conditions:

• Capture a specific town.
• Defeat a specific hero.
• Lose a specific town.
• Lose a specific hero.

It adds functions to get a list of heroes or towns present on the map.

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[Branikolog]

Hi. Great work on this PR!
I've taken a look at this PR and here are some issues I found:

When I start the map with such victory condition (the castle owned by red player) I automatically loose. There's no sense allowing checkbox for already owned castle to create such map, that is unplayable. (It works the same as in the original game though.)
In my personal opinion, that castle already owned by one enemy can be the special wining condition for all other players. So once it is captured by another player - then he wins. Why not?
Edge of the world 10.zip

In a case I play a single game - loose condition works as expected.
If I start multiplayer for 2 players - nothing happens, when AI captures my castle.
I suggest specifying loosing condition (castles or heroes) individually for each human controlled player so mapmakers could create fair scenarios for all players.

Edge of the world 1.zip

There's also one question that bothers me for multiplayer games: if one player fails (regarding loosing condition) what happens to his rest heroes and castles?

[Branikolog]

Not sure it's related to the current PR, but I somehow cannot select other players:

Also there's one more issue:

Blue and green players have similar castle set ups, but I can select starting faction only for green player.

[ihhub]

Hi @Branikolog , described by you conditions work exactly as in the original Editor. I believe it is a place of improvement for it but definitely not bugs in my opinion.

[ihhub]

@Branikolog and @Districh-ru , I fixed invalid race setup logic. Please take a look.

In order to reflect the change you have to resave the map to update its conditions.

[Branikolog]

Hi, @ihhub

Hi @Branikolog , described by you conditions work exactly as in the original Editor. I believe it is a place of improvement for it but definitely not bugs in my opinion.

The original editor in this regard was kind of broken in my opinion. I think we shouldn't allow to create such maps, that are broken and unplayable (in terms of conditions).
I hope you can fix the most apparent issues within future PRs.

[Districh-ru]

Hi, @Branikolog, I've addressed the first issue: now the "Allow this condition also for AI" checkbox is available only for the neutral towns/castles.

Let's address the other issues with the special victory/loss conditions in multiplayer in the other PR, because it's more related to the multiplayer logic that most likely needs polishing.

[Branikolog]

Hi, @Districh-ru !

Let's address the other issues with the special victory/loss conditions in multiplayer in the other PR, because it's more related to the multiplayer logic that most likely needs polishing.

Sure! I find current implementation not really easy to catch, when I start selecting Human-only/Comp-human/Comp-only players and trying to set special conditions.

[zenseii]

@Districh-ru. I left some more suggestions for better phrasing. Please have a look when it is convenient for you.

Something about "for victory" and "for defeat" sounded awkward to me, so I tried my best to rephrase them.

[ihhub]

Hi @zenseii , I've addressed your comments. Could you please check again?

[ihhub]

@Districh-ru , many thanks for implementing such features!