Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow skipping docs installation #8911

Closed
wants to merge 3 commits into from

Conversation

lemenkov
Copy link

@lemenkov lemenkov commented Jul 3, 2024

Application packaging sometimes requires to list docs explicitly in a packaging' setup file and sometimes even package some of them (namely license file) separately. In this case an extra installation step becomes unnecessary. This patch allows packager to skip it.

Application packaging sometimes requires to list docs explicitly
in a packaging' setup file and sometimes even package some of them
(namely license file) separately. In this case an extra installation
step becomes unnecessary. This patch allows packager to skip it.

Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
@oleg-derevenetz oleg-derevenetz added improvement New feature, request or improvement deployment Deployment stuff (distributions, installers, etc) CMake CMake related stuff labels Jul 3, 2024
@oleg-derevenetz oleg-derevenetz added this to the 1.1.1 milestone Jul 3, 2024
@ihhub
Copy link
Owner

ihhub commented Jul 7, 2024

Hi @lemenkov , could you please point to well-known libraries that use such a step for CMake? As I see we are going to add an extra option just for the sake of saving space for 3 files.

@lemenkov
Copy link
Author

lemenkov commented Jul 8, 2024

Hi @lemenkov , could you please point to well-known libraries that use such a step for CMake?

Nope, nothing comes to my mind.

@ihhub
Copy link
Owner

ihhub commented Jul 10, 2024

Hi @lemenkov , could you please point to well-known libraries that use such a step for CMake?

Nope, nothing comes to my mind.

Then I don't understand the benefit of doing this step for CMake. I haven't seen any software that doesn't copy license files into an installation location. Please explain if something I am missing for this change.

@ihhub ihhub modified the milestones: 1.1.1, 1.1.2 Jul 10, 2024
@lemenkov
Copy link
Author

Hello, and sorry for the delayed answer. First I handled this a bit differently so I do not need this PR any more.

The issue we need to treat License data and other supplementary doc-files differently while packaging. So I do not need them to be installed at all - I pick them up during the packaging stage. Anyway it's not a big deal and I am going to close it.

@lemenkov lemenkov closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake related stuff deployment Deployment stuff (distributions, installers, etc) improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants