Handle the SDL events strictly in turn #8912
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
oleg-derevenetz
added
SDL2
|
@oleg-derevenetz . I've tried it out. First impressions, keyboard now works well. Strangely mouse has double click now. I tried multiple mice, and they all do the same thing. I tried a separate double detection click app, and it suggests the mouse doesn't double click. |
That's because SDL emulates fake touch events from the mouse events, and vice versa. The latter has already been disabled, while the former has not, so each mouse press or release event generated the corresponding fake touch event. Now this behavior is disabled too, so there should be no more "double clicks", please try the latest Android artifact from this PR. |
|
Hi @denierlexiese do you still have any input issues (with keyboard, mouse or touch) with the Android binary from this PR after the latest changes (disabled generation of fake touch events from mouse events)? |
|
@oleg-derevenetz - yes it works well now.Thank you!. It works well even in usb-c mode with both touch, mouse, and keyboard. |
|
Hi @ihhub probably this PR should be postponed after the upcoming release - depending on your release schedule. |
|
Hi @oleg-derevenetz , the release is scheduled in 3 days so it would be safer to merge this PR after the release. |
|
Hi @oleg-derevenetz , the only worry of mine is that could cause delays of event processing on low end devices when software cursor mode is active. I will try to do some tests on my machine to see how it works. |
|
@oleg-derevenetz , quick note, when I hook my surface duo up to a 4k monitor the fps drops to 30. The mouse and keyboard are really slow, like lags behind 3 to 4 frames. Not sure what's the cause. The surface duo is annoying because it seems like it isn't able to downscale to 1080p only does the resolution of the output monitor. On my 1080p monitors the game runs fine. On my 4k, even with a resolution in the game of 800x600 it runs really slow on a 4k monitor. Could be a surface duo thing. Just noting odd behavior. |
|
Hi @denierlexiese please note that the build from this PR is a debug build with all compiler optimizations turned off. It is not indicative in terms of the game performance, including the performance of the rendering, which is done in software. Real game performance needs to be evaluated on release builds. |
BTW, is this observed on the Google Play build as well (except the keyboard of course)? |
|
Yes, I believe you are correct, that on the Google play build it will get slow on my surface duo as well at large resolutions for mouse lag. On my galaxy phone it doesn't, but I believe my galaxy phone forces 1080p no matter what TV it's running on. |
|
@oleg-derevenetz , a bunch of thanks for this fix! |
fix #8910