-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Earthquake spell animation and improve its logic to allow bridge and nearby towers demolition (Battlefield) #9011
Update Earthquake spell animation and improve its logic to allow bridge and nearby towers demolition (Battlefield) #9011
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
…thout turrets by the Earthquake spell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Hi @Districh-ru I decided to make an effort to rewrite the logical part of the catapult and Earthquake spell operation to make it a little less confusing (I hope) and add a variety of assertions and checks. I will be checking the new implementation over the next couple of days. I hope that you will also take a look at it and express your comments, if any. As soon as I decide that the logic has been sufficiently tested, I will mark this PR as approved. |
Hi @ihhub and @oleg-derevenetz , from tomorrow I'll be on leave and for the next two weeks (or possibly till september) I'll be far from home and internet and will not be able to maintain the project. |
@Districh-ru Thank you very much! |
Fix #7489, fix #7478
Changes in this PR:
fheroes2.2024-07-28.19-11-46-793.mp4