WIP: GitLab Ci master #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start moving stuff into separate modules
notify: replace unfiltered with filtered alerts
Useability for the form is horrible, and will be fixed after silences are being created.
Need to update API to accept destroy verb.
To be removed in a refactor ..
* Wait for test server to be ready before running tests This fixes problems when running the acceptance tests in slow or CPU-starved machines, as mentioned in prometheus#472.
* Create set of labelKeys * Wip (compiling) * Add naive levenshtein distance Need to check out the fzf fuzzy algo, this is just a place holder for now. https://github.com/junegunn/fzf/blob/master/src/algo/algo.go * Hack a groupBy into the code This needs massive cleanup and is just a late-night spike. Everything in this commit needs to be re-organized, most likely. * Update some html/css * Set input validation for label filtering * Add Jaro-Winkler string comparison * remove levenshtein stuff * Fix match tests * Read actual Jaro definition if ml == 0, then the distance == 0 * Use correct searchLength implementation * Limit searching string to matchRange Only search matchRange when looking for matches, instead of going through every value and then deciding if it should be checked based on its position. Data generated from https://ellie-app.com/38cXFnRLjcga1/1 matchCharmatchChar2delta mean ops/sec 346,928.55 (stddev: 12,306.94, 3.55%) 364,551.61 (stddev: 10,561.94, 2.9%) +5.08% mean runtime 2.886ns (stddev: 103.748µs, 3.59%) 2.745ns (stddev: 80.856µs, 2.95%) -4.87% total runtime 5.022s 5.052s sampling 48 runs of 30,000 calls 46 runs of 40,000 calls * Fix off-by-one error in List slicing * Simplify transition calculation * Keyboard controls for the autocomplete * Fix clicking on the results * Rename AutoComplete to GroupBar * Broke apart the view function * Fix the layout * Change button style * Synchronize grouping with URL * Fix tests * Added toggle silenced alerts * Remove comment * Roll back the labelButton * Always fetch the alerts * Disable show silenced * Extract alert groups * Rename tests * Use more generic number instead of int * Restore showSilenced * Update ui/bindata.go * Update template/internal/deftmpl/bindata.go * Update bindata.go * Reformat with updated elm-format
* Simplify silence modifications, add update endpoint * vendor: add pkg/errors * ui: Handle upserting of silences . * Regenerate bindata
Remove receiver filtering from backlink
This adds the silenced query parameter to the /alerts API endpoint. In addition it changes the default in the UI. Previously silenced alerts were displayed by default. This PR hides silenced alerts by default.
Add 'silenced' query param to /alerts endpoint
* Restyle SilenceForm view * Add validation to SilenceForm * Redirect to new silence when editing expired one
Rework SilenceForm
*: cut v0.7.0-rc.0
silence: fix and test expiration behavior
* Get rid of old css lib * Cleanup the models and updates * Styled the silences view * Update that bindata stuff
Correct change types in 0.6.x changelogs
* Restructure the validation * Validate on blur * Extract alerts from the silence * Use string for the error type * Use ApiData everywhere * Validate the form * Remove redirect on failure * Code review fixes * Hide the delete button if there is one matcher * Rename silence2 * Update bindata.go * Fix the tests * Actually hide the delete button * Update bindata.go
Instead of targeting the latest build, which could be any PR, we should target current master results.
…rometheus#820) Do not expose resolved alerts on the /alerts endpoint. Do not send resolved alerts to receivers if the alerts have never been fired before.
Instead of setting endsAt to startsAt we can set both to now. Thereby the Silence will get the expired state by default.
Expire pending silence and move to expired state
* Show annotations * Update bindata.go * Fix the versions of elm modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.