Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing subprocess wrapper is called #8

Closed
deldesir opened this issue Nov 1, 2023 · 0 comments
Closed

Ensure existing subprocess wrapper is called #8

deldesir opened this issue Nov 1, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@deldesir
Copy link
Collaborator

deldesir commented Nov 1, 2023

Describe the bug/problem

The current implementation in editbooks.py utilizes direct imports from the subprocess module, which diverges from the consistent practice within the Calibre-Web codebase. To ensure uniformity and maintain code standardization, the file should use the subproc_wrapper.py as an interface for interacting with subprocesses, for #6.

To Reproduce

There is no specific bug to reproduce; this issue pertains to code consistency and best practices within the Calibre-Web project.

Expected behavior

Refactoring the code in editbooks.py to utilize the subproc_wrapper.py should lead to seamless subprocess operations in line with the established code standards.

Environment (please complete the following information):

Additional context

It's recommended to review the code changes thoroughly, ensuring that the substitution from direct subprocess imports to the subproc_wrapper.py maintains or improves the functionality without introducing any regressions. The modification should promote uniformity in the codebase and simplify future maintenance tasks related to subprocess interactions.

@deldesir deldesir changed the title Ensure current subprocess wrapper is called Ensure existing subprocess wrapper is called Nov 1, 2023
@deldesir deldesir self-assigned this Nov 1, 2023
@deldesir deldesir added the enhancement New feature or request label Nov 1, 2023
This was referenced Nov 2, 2023
@holta holta closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants