You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation in editbooks.py utilizes direct imports from the subprocess module, which diverges from the consistent practice within the Calibre-Web codebase. To ensure uniformity and maintain code standardization, the file should use the subproc_wrapper.py as an interface for interacting with subprocesses, for #6.
To Reproduce
There is no specific bug to reproduce; this issue pertains to code consistency and best practices within the Calibre-Web project.
Expected behavior
Refactoring the code in editbooks.py to utilize the subproc_wrapper.py should lead to seamless subprocess operations in line with the established code standards.
Environment (please complete the following information):
It's recommended to review the code changes thoroughly, ensuring that the substitution from direct subprocess imports to the subproc_wrapper.py maintains or improves the functionality without introducing any regressions. The modification should promote uniformity in the codebase and simplify future maintenance tasks related to subprocess interactions.
The text was updated successfully, but these errors were encountered:
deldesir
changed the title
Ensure current subprocess wrapper is called
Ensure existing subprocess wrapper is called
Nov 1, 2023
Describe the bug/problem
The current implementation in
editbooks.py
utilizes direct imports from thesubprocess
module, which diverges from the consistent practice within the Calibre-Web codebase. To ensure uniformity and maintain code standardization, the file should use thesubproc_wrapper.py
as an interface for interacting with subprocesses, for #6.To Reproduce
There is no specific bug to reproduce; this issue pertains to code consistency and best practices within the Calibre-Web project.
Expected behavior
Refactoring the code in
editbooks.py
to utilize thesubproc_wrapper.py
should lead to seamless subprocess operations in line with the established code standards.Environment (please complete the following information):
Additional context
It's recommended to review the code changes thoroughly, ensuring that the substitution from direct
subprocess
imports to thesubproc_wrapper.py
maintains or improves the functionality without introducing any regressions. The modification should promote uniformity in the codebase and simplify future maintenance tasks related to subprocess interactions.The text was updated successfully, but these errors were encountered: