Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online media download support #6

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Online media download support #6

merged 5 commits into from
Nov 1, 2023

Conversation

deldesir
Copy link
Collaborator

This adds feature to download media from major videos platforms. When a link is submitted using the download button, the server side logic (/media route) adds the download video(s) to the library ensuring correct (available) metadata are also extracted.

Tested on Ubuntu 23.10.

Online media download support and bookshelf creation automation
Media query handling using a modal dialog
Add "media download" modal dialog
Metadata fetch reading database
@holta
Copy link
Member

holta commented Oct 30, 2023

This PR appears to (begin to remove? or completely remove?) mkv, avi and other formats (video formats especially?) that lack native browser support:

elif extension_upper in ['.MP4', '.WEBM']]:

(@deldesir can clarify!)

@deldesir
Copy link
Collaborator Author

deldesir commented Oct 30, 2023

This PR begins to remove media files that are not (or not well) supported natively by popular browsers. Mkv files, for example, are not playable in the browser and videojs cannot be used to handle them.

@holta
Copy link
Member

holta commented Nov 8, 2023

FYI this PR replaced the earlier:

@holta
Copy link
Member

holta commented Nov 8, 2023

FYI this PR also implements:

deldesir added a commit that referenced this pull request Nov 29, 2023
Update calibre-web-nginx.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional media upload and download Should bare URLs like "youtu.be/Mt187r0Ec9A" work in future?
2 participants