Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve relevant description #116

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

deldesir
Copy link
Collaborator

🚀 Pull Request Overview:

This pull request retrieves the correct description for each video.

📋 Checklist:

  • Tested the changes thoroughly.

📌 Testing scenarios:
See Issue #97

cc @EMG70

PS This PR builds upon #110 to #114

@deldesir deldesir requested a review from holta January 31, 2024 13:14
@deldesir deldesir self-assigned this Jan 31, 2024
@holta holta mentioned this pull request Jan 31, 2024
2 tasks
@holta
Copy link
Member

holta commented Jan 31, 2024

FYI my understanding is this PR patches a small functionality regression introduced by:

@deldesir
Copy link
Collaborator Author

Tested on LRN2:

Before (with incorrect description, prior to applying this PR):
before

After (with correct description, after applying this PR):
after

@EMG70
Copy link

EMG70 commented Jan 31, 2024

iiab-diagnostics http://sprunge.us/XPsd7T?en
Downloaded videos appear with full title in Tasks.The video url is now clickable.Good progress @deldesir ,your screenshots were very helpful in the testing .I will keep testing and update.
Screenshot from 2024-01-31 17-17-15

A scrollable full video description is showing Ok.see screenshot.
Screenshot from 2024-01-31 18-03-35

@EMG70
Copy link

EMG70 commented Jan 31, 2024

Just to add,the first video in the playlist shows progress until 62% and stalled ,the rest were in "waiting " status .Downloading progressed in the background until all were successfully downloaded.

@holta holta added the bug Something isn't working label Feb 14, 2024
@deldesir deldesir deleted the deldesir-description-1 branch July 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants