Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [FFmpeg] scene detection filter [to make thumbnail/cover/poster creation more reliable] #225

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Jul 16, 2024

Makes the video cover generation upon upload failsafe for some videos with little scene changes.

Tested on Ubuntu 24.04 (LRN2)
image

Fixes #214

@deldesir deldesir marked this pull request as draft July 16, 2024 21:41
@deldesir deldesir requested a review from holta July 16, 2024 21:46
@deldesir deldesir self-assigned this Jul 16, 2024
@deldesir deldesir added the bug Something isn't working label Jul 16, 2024
@deldesir deldesir marked this pull request as ready for review July 16, 2024 21:47
@holta
Copy link
Member

holta commented Jul 16, 2024

Great!

@deldesir or any FFmpeg wizards should feel free to add more elegant thumbnails/covers/posters at a later date, if this is failsafe!

@holta holta merged commit 6ba8be7 into iiab:master Jul 16, 2024
@holta holta changed the title Remove the scene detection filter Remove [FFmpeg] scene detection filter [to make thumbnail/cover/poster creation more reliable] Jul 16, 2024
@holta
Copy link
Member

holta commented Jul 16, 2024

@deldesir should the "apply filters to avoid black frames and scale" comment be slightly revised, e.g. if black / background frames are no longer being avoided?

'-vf', 'fps=1,thumbnail,scale=-1:720', # apply filters to avoid black frames and scale

@deldesir
Copy link
Collaborator Author

deldesir commented Jul 16, 2024

You're right, It's not accurate anymore. Done in #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants