-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts/lb-wrapper: Try yt-dlp with "--format best --format-sort 'tbr~1000'" [testing shows need for URL validation, clearly communicated, for users who accidentally request the impossible after clicking "Download to IIAB" > "Start"] #63
Conversation
@EMG70 explanation is emerging at:
(If this explanation contains shortcomings, please shout with your suggestions!) |
MKV Results may not yet be 100% ideal, but perhaps good enough for now?
Binary Search Algorithm in 100 Seconds |
502 Bad Gateway upon entering http://ip/books |
pastebinit -b sprunge.us//var/log/xklb.log pastebinit -b sprunge.us/var/log/calibre-web.log |
@deldesir can you help us understand why Line 86 is very different from the others?
|
CLARIFICATION**** I thought the link was corrupted so tried another one yt-dlp --format "bv*[ext=mp4]+ba[ext=m4a]/b[ext=mp4]" https://www.youtube.com/watch?v=sOE8Slo3Pqw" |
Thanks @EMG70 for clarifying: @deldesir can we learn anything from this? (ASIDE: Certainly we need much stronger URL validation — when people click on "Download to IIAB" — so the front-end makes 100% clear telling them exactly what the back-end is and is not capable of, i.e. based on the URL they request!) |
@EMG70 advised me to go ahead and merge this after his extensive testing today: Huge Thanks to him for his very hard work, confirming this PR is generally very solid i.e. an earnest real step forward helping schools/parents/kids getting the very manageable/tolerable codecs they need in offline and low-income communities! |
@deldesir @EMG70 please consider testing this alternative alongside:
Building on: