Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow existing item with matching names in io.maybe_init_item() #294

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Mar 26, 2020

Follow-up for #289; required for iiasa/message_ix#321.

How to review

Confirm CI checks pass.

PR checklist

  • Tests added. The method is still 100% covered.
  • Documentation added. N/A
  • Release notes updated. N/A

@khaeru khaeru added this to the 3.0 milestone Mar 26, 2020
@khaeru khaeru self-assigned this Mar 26, 2020
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #294 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   97.38%   97.38%           
=======================================
  Files          39       39           
  Lines        3979     3980    +1     
=======================================
+ Hits         3875     3876    +1     
  Misses        104      104           
Impacted Files Coverage Δ
ixmp/backend/io.py 98.16% <100.00%> (ø)
ixmp/core.py 95.72% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0540329...a6580ff. Read the comment docs.

@khaeru khaeru merged commit 3e16ec8 into iiasa:master Mar 26, 2020
@khaeru khaeru deleted the io-maybe-init-item branch March 26, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant