Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some Java exceptions to RuntimeError #362

Merged
merged 3 commits into from
Aug 20, 2020
Merged

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Aug 20, 2020

Closes #172.
Closes #194.
Closes #236.

These are all, however, workarounds; #296 would be the complete fix.

How to review

Note that the CI checks all pass.

PR checklist

  • Tests added.
  • Documentation added.
  • Release notes updated.

@khaeru khaeru added the backend.jdbc Interaction with ixmp_source via JDBCBackend & JPype label Aug 20, 2020
@khaeru khaeru added this to the 3.1 milestone Aug 20, 2020
@khaeru khaeru self-assigned this Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #362 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   96.54%   96.60%   +0.05%     
==========================================
  Files          45       45              
  Lines        5239     5243       +4     
==========================================
+ Hits         5058     5065       +7     
+ Misses        181      178       -3     
Impacted Files Coverage Δ
ixmp/backend/jdbc.py 96.39% <100.00%> (+0.55%) ⬆️
ixmp/tests/backend/test_jdbc.py 83.78% <100.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b174cef...a9b1228. Read the comment docs.

@khaeru khaeru force-pushed the issue/236 branch 2 times, most recently from 4aed207 to 7626ccc Compare August 20, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend.jdbc Interaction with ixmp_source via JDBCBackend & JPype
Projects
None yet
1 participant