Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace resolved numpy workaround with dask workaround #887

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Nov 11, 2024

This PR tries to resolve the CI test failures by not using version 2024.11.0 of dask, which is causing issues with genno.

The most preferable solution would be to adapt genno to this dask version, but it is unclear how much effort this would be and how long this would take. So for now, I'm simply imposing that we don't use that particular version (note: 2024.11.1 would be allowed, hoping that this might resolve the incompatibilities).
If this workaround is successful and we agree we want to employ it for now, we should also adopt it in the nightly workflow.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update CI tests; coverage checks both ✅
  • [ ] Add, expand, or update documentation. Just CI.
  • [ ] Update release notes. Just CI.

@glatterf42 glatterf42 added the ci Continuous integration label Nov 11, 2024
@glatterf42 glatterf42 self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.5%. Comparing base (9d9f5bd) to head (d177d2a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #887   +/-   ##
=====================================
  Coverage   95.5%   95.5%           
=====================================
  Files         46      46           
  Lines       4340    4340           
=====================================
  Hits        4148    4148           
  Misses       192     192           

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I would only suggest to use dask < 2024.11.0 instead of dask != 2024.11.0.

The reason is that, until or unless we make a report to dask upstream and they choose to fix it, we should expect that future releases of dask (e.g. 2024.11.1, 2024.12.0, 2025.1.0) will also cause the same errors.

Using < avoids any need to adjust the workaround.

@glatterf42
Copy link
Member Author

Thanks, sounds good :)
I can open a PR similar to this one on message-ix-models, too.

@glatterf42 glatterf42 merged commit afd7420 into main Nov 11, 2024
26 checks passed
@glatterf42 glatterf42 deleted the fix/CI-dask-numpy branch November 11, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants