Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GAMS version in nightly CI worklow #892

Merged
merged 6 commits into from
Nov 21, 2024
Merged

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Nov 21, 2024

Similar to iiasa/message-ix-models#250 (review), I'm hoping today's nightly CI test failure also just arises from an incompatibility of using an older GAMS version but a newer GAMS license for this kind of run. This PR thus bumps the GAMS version in the nightly workflow and temporarily enables them to make sure the fix works.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Update tests; coverage checks both ✅
  • ~[ ] Add, expand, or update documentation. ~ Just CI.
  • ~[ ] Update release notes. ~ Just CI.

@glatterf42 glatterf42 added the ci Continuous integration label Nov 21, 2024
@glatterf42 glatterf42 self-assigned this Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.6%. Comparing base (618e13a) to head (3c16a74).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
message_ix/tests/test_nightly.py 0.0% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #892     +/-   ##
=======================================
- Coverage   95.6%   95.6%   -0.1%     
=======================================
  Files         46      46             
  Lines       4335    4337      +2     
=======================================
  Hits        4147    4147             
- Misses       188     190      +2     
Files with missing lines Coverage Δ
message_ix/tests/test_nightly.py 0.0% <0.0%> (ø)

@glatterf42
Copy link
Member Author

I've been looking at events that trigger CI runs and I've stumbled upon pull_request_target. If I'm not mistaken, this can close #603 since the nightly tests will now automatically run on every PR that changes any GAMS file (.gms, .gpr, and .gdx for now).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seems to not be considered for our coverage report, so new lines here are considered untested. I'd argue this should not stop this PR, though.

- '**.gpr'
- '**.gdx'
types:
- labeled
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, our secrets could be extracted by any workflow changing GAMS files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the tests passed before, so I disabled them again. They won't run when we apply a label to this PR because it would need to clear both filters, i.e. change some GAMS files and get a label to run.

.github/workflows/pytest.yaml Outdated Show resolved Hide resolved
@glatterf42 glatterf42 merged commit b0365d6 into main Nov 21, 2024
25 of 26 checks passed
@glatterf42 glatterf42 deleted the fix/globiom-ci-gams branch November 21, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants