-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the subtitle and site-nav-toggle are overlapping on the mobile case #1501
base: master
Are you sure you want to change the base?
Conversation
@Jacksgong and on other resolutions how it will look? |
Because of the subtitle is horizontal-center, so if the subtitle is short you will can't reproduce such problem, but if the subtitle is a little long you can reproduce such problem on the mobile case very easy. |
I have fixed such problem on my blog. |
Tested it. 35% from the top - it's not right for alignment. |
@Jacksgong see, i have 4 screens in different resolutions: |
@ivan-nginx I think this way is good enough to fix most resolution cases on the mobile, If you care about all cases there is no solution because tons of problem will occur, such as: |
@ivan-nginx And I think you are misunderstanding with this solution. This solution just effect for mobile case, what is if the browser width less than or equal to
So the problem of below is another problem, not on the mobile case: |
@Jacksgong upper your screen - it's not right resolution on any mobile devices. =) |
@ivan-nginx it has been tested on my phone, and you can test it on chrome development tools with any resolution you want easily. Also thanks for the test website you provided. |
This might be the quick fix based on current implementation of mobile menu toggle, and I think it is acceptable for now. Another solution is to use a flex or fluid layout to separate the header section into 3 pieces:
This should be the better one. What do you think? @Jacksgong @ivan-nginx |
That's right. See, i was made flex style on social fb & vk like buttons there: https://github.com/iissnan/hexo-theme-next/pull/1381/files#diff-a27b6018d8564ec7bbd5895a07822ec6R46 |
Thanks, you are right, flex or fluid layout would be better choise. |
Fixed in theme-next/hexo-theme-next#1387 using flex layout |
fix the subtitle and site-nav-toggle are overlapping on the mobile case:
Problem
Fixes