Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error with maturin 1.8.0 #541

Closed
Staudey opened this issue Dec 25, 2024 · 6 comments
Closed

Build error with maturin 1.8.0 #541

Staudey opened this issue Dec 25, 2024 · 6 comments

Comments

@Staudey
Copy link

Staudey commented Dec 25, 2024

Building with maturin 1.8.0 fails with the following error:

💥 maturin failed
  Caused by: `project.version` field is required in pyproject.toml unless it is present in the `project.dynamic` list

Corresponding maturin change: PyO3/maturin#2391

So rather than filling in the version, maturin should error and tell the user to add dynamic = ["version"] to their pyproject.toml
(from PyO3/maturin#2390)

@HythemK
Copy link

HythemK commented Dec 27, 2024

Met the same error yesterday

@esaaprillia
Copy link

the same mistake

@steals
Copy link

steals commented Dec 27, 2024

Same issue when trying to install orjson 3.10.12 on armv6

@HythemK
Copy link

HythemK commented Dec 27, 2024

Same issue when trying to install orjson 3.10.12 on armv6

I soleved this by downloading tar.gz from pypi and then edit the pyproject.toml to right format.
Use pip install . to install it.

@ijl
Copy link
Owner

ijl commented Dec 29, 2024

Fixed in 3.10.13. If you are not building strictly for your own use, there is nothing to do but upgrade to at least this version (or wait for maturin to possibly revert the breaking change).

@ijl ijl closed this as completed Dec 29, 2024
@tobypeterson
Copy link

tobypeterson commented Dec 30, 2024

Now it doesn't build because it explicitly requires maturin 1.7.8. The PR from @Staudey should fix the issue in a more permanent fashion that won't require updating the version in pyproject.toml for each release.

I wouldn't expect a maturin revert; based on everything I've read, the change was intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants