Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml: Specify version metadata as dynamic #542

Closed
wants to merge 1 commit into from
Closed

pyproject.toml: Specify version metadata as dynamic #542

wants to merge 1 commit into from

Conversation

Staudey
Copy link

@Staudey Staudey commented Dec 26, 2024

Fixes build with maturin 1.8.0

Resolves #541

@Staudey
Specify version metadata as dynamic
069bcde 
Fixes build with maturin 1.8.0

Signed-off-by: Thomas Staudinger <Staudi.Kaos@gmail.com>
@ijl
Copy link
Owner

ijl commented Dec 29, 2024

Probably marginally better to specify a fixed version so I've done that, but thanks.

@ijl ijl closed this Dec 29, 2024
@musicinmybrain
Copy link
Contributor

When maturin made this change, they cited the offical pyproject.toml spec to show that the old behavior was noncompliant. I would therefore not expect the change to be reverted in the future.

Why not just add the one line to pyproject.toml, as in this PR, rather than pinning an old version of maturin indefinitely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build error with maturin 1.8.0
3 participants
@Staudey @ijl @musicinmybrain