Default to str() for Unknown objects as keys when using OPT_NON_STR_KEYS
#454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
changed the title
OPT_NON_STR_KEYSOPT_NON_STR_KEYS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #438, which was closed as stale.
This is a feature to allow unknown types (e.g. a custom implementation of an enum in my case, but could be anything) to be keys by just naively relying on the string representation. This is not elegant, and I agree with @ijl that "This is a sort of feature request if you squint", but the current behavior is to error so I think this is a marginal improvement on that. Happy to make any changes.