Introduce TypeScript #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
force-pushed
the
introduce-typescript
branch
from
6b94ca9
to
10d026f
Compare
ijlee2
commented
Jun 12, 2023
Comment on lines
+88
to
+91
| "pnpm": { | ||
| "overrides": { | ||
| "eslint-plugin-import@2.27.5>tsconfig-paths": "^4.2.0" | ||
| } |
There was a problem hiding this comment.
Temporarily fixes import-js/eslint-plugin-import#2751.
ijlee2
commented
Jun 12, 2023
| "bin": "./bin/ember-codemod-pod-to-octane.js", | ||
| "directories": { | ||
| "test": "tests" | ||
| }, | ||
| "files": [ | ||
| "bin/", | ||
| "src/" | ||
| "dist" |
There was a problem hiding this comment.
At the moment, I'm unsure whether an end-developer will be able to continue to use npx to run the codemod. Will check this after publishing a new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By introducing TypeScript, we can improve documentation and maintainability of this project. In addition, the pull request checks that these utility packages shipped types correctly: