Skip to content

Commit

Permalink
Added ember-lts-5.4 to ember-try scenarios (#219)
Browse files Browse the repository at this point in the history
* chore: Allowed the latest Node 18.x

* chore: Updated setup-node action to v4

* chore: Added ember-lts-5.4 scenario

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
  • Loading branch information
ijlee2 and ijlee2 authored Dec 20, 2023
1 parent 600d9ff commit 855d34c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
pull_request:

env:
NODE_VERSION: 18.17
NODE_VERSION: 18
PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }}
PERCY_PARALLEL_TOTAL: 9

Expand All @@ -32,7 +32,7 @@ jobs:
version: latest

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: ${{ env.NODE_VERSION }}
Expand All @@ -59,7 +59,7 @@ jobs:
version: latest

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: ${{ env.NODE_VERSION }}
Expand Down Expand Up @@ -124,7 +124,7 @@ jobs:
version: latest

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: ${{ env.NODE_VERSION }}
Expand Down Expand Up @@ -167,7 +167,7 @@ jobs:
version: latest

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: ${{ env.NODE_VERSION }}
Expand All @@ -190,6 +190,7 @@ jobs:
- 'ember-lts-4.4'
- 'ember-lts-4.8'
- 'ember-lts-4.12'
- 'ember-lts-5.4'
- 'ember-release'
- 'ember-beta'
- 'ember-canary'
Expand All @@ -206,7 +207,7 @@ jobs:
version: latest

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
cache: 'pnpm'
node-version: ${{ env.NODE_VERSION }}
Expand Down
8 changes: 8 additions & 0 deletions test-app/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,14 @@ module.exports = async function () {
},
},
},
{
name: 'ember-lts-5.4',
npm: {
devDependencies: {
'ember-source': '~5.4.0',
},
},
},
{
name: 'ember-release',
npm: {
Expand Down

0 comments on commit 855d34c

Please sign in to comment.