Skip to content

Commit

Permalink
Made pnpm settings stricter (#245)
Browse files Browse the repository at this point in the history
* chore: Updated pnpm to 9.9.0

* chore: Set auto-install-peers and resolve-peers-from-workspace-root to false

* chore: Updated lockfile

* chore: Added changeset

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
  • Loading branch information
ijlee2 and ijlee2 authored Sep 5, 2024
1 parent 3453d44 commit c242829
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 332 deletions.
7 changes: 7 additions & 0 deletions .changeset/four-dryers-notice.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"docs-app": patch
"ember-container-query": patch
"test-app": patch
---

Made pnpm settings stricter
11 changes: 0 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ env:
NODE_VERSION: 18
PERCY_PARALLEL_NONCE: ${{ github.run_id }}-${{ github.run_number }}
PERCY_PARALLEL_TOTAL: 9
PNPM_VERSION: 9

jobs:
lint:
Expand All @@ -29,8 +28,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: ${{ env.PNPM_VERSION }}

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand All @@ -56,8 +53,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: ${{ env.PNPM_VERSION }}

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -121,8 +116,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: ${{ env.PNPM_VERSION }}

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -164,8 +157,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: ${{ env.PNPM_VERSION }}

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -205,8 +196,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: ${{ env.PNPM_VERSION }}

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down
4 changes: 3 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
strict-peer-dependencies=false
# https://github.com/emberjs/rfcs/pull/907
auto-install-peers=false
resolve-peers-from-workspace-root=false
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"concurrently": "^8.2.2",
"update-workspace-root-version": "^0.3.0"
},
"packageManager": "pnpm@9.7.0",
"packageManager": "pnpm@9.9.0",
"engines": {
"node": "18.* || >= 20",
"pnpm": ">= 9"
Expand Down
Loading

0 comments on commit c242829

Please sign in to comment.