Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs and test apps #212

Merged
merged 9 commits into from
Oct 15, 2023
Merged

Updated docs and test apps #212

merged 9 commits into from
Oct 15, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Oct 15, 2023

Description

The demo app for ember-container-query shares code with embroider-css-modules and ember-workshop. I recently updated the latter two, so it's time to update this repo's app.

Notes

I couldn't convert <Widgets::Widget-3> to a <template>-tag component. It would need to import <Widgets::Widget-3::TourSchedule> in the .gts file, but there seems to be a bug in Embroider:

/* This didn't work */
import WidgetsWidget3TourSchedule from './widget-3/tour-schedule';
[docs-app] Build Error (PackagerRunner) in components/widgets/widget3/tour-schedule.ts
[docs-app] 
[docs-app] Module build failed (from ../../../../node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/cjs.js):
[docs-app] Thread Loader (Worker 0)
[docs-app] ENOENT: no such file or directory, open '/docs-app/node_modules/.embroider/rewritten-app/components/widgets/widget3/tour-schedule.ts/tour-schedule.ts'
[docs-app]     at PoolWorker.fromErrorObj (/node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/WorkerPool.js:346:12)
[docs-app]     at /node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/WorkerPool.js:219:29
[docs-app]     at mapSeries (/node_modules/.pnpm/neo-async@2.6.2/node_modules/neo-async/async.js:3625:14)
[docs-app]     at PoolWorker.onWorkerMessage (/node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/WorkerPool.js:173:34)
[docs-app]     at /node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/WorkerPool.js:146:14
[docs-app]     at Socket.onChunk (/node_modules/.pnpm/thread-loader@3.0.4_webpack@5.89.0/node_modules/thread-loader/dist/readBuffer.js:40:9)
[docs-app]     at Socket.emit (node:events:514:28)
[docs-app]     at Readable.read (node:internal/streams/readable:539:10)
[docs-app]     at Socket.read (node:net:750:39)
[docs-app]     at flow (node:internal/streams/readable:1023:34)
[docs-app]     at emitReadable_ (node:internal/streams/readable:604:3)
[docs-app]     at process.processTicksAndRejections (node:internal/process/task_queues:81:21)

Maybe the combination of hyphen, followed by an ending number, causes an issue? (Renaming the folder widget-3 to widget3 seemed to fix the build error.)

@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Oct 15, 2023
@ijlee2 ijlee2 changed the title Updated docs-app Updated docs and test apps Oct 15, 2023
@ijlee2 ijlee2 marked this pull request as ready for review October 15, 2023 08:39
@ijlee2 ijlee2 merged commit a9a0abc into main Oct 15, 2023
26 checks passed
@ijlee2 ijlee2 deleted the update-docs-app branch October 15, 2023 08:44
width: number;
};

export function assertDimensions(assert: Assert, dimensions: Dimensions): void {
Copy link
Owner Author

@ijlee2 ijlee2 Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only is this function easier to type (before, CustomAssert had tried to append things to the assert type that qunit-dom already builds on top of qunit), the tests seem to now finish sooner (~35 seconds before, ~23 seconds now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant