-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated docs and test apps #212
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlee2
added
the
enhance: documentation
Issue asks for better documentation (e.g. README, code, tests)
label
Oct 15, 2023
ijlee2
commented
Oct 15, 2023
width: number; | ||
}; | ||
|
||
export function assertDimensions(assert: Assert, dimensions: Dimensions): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only is this function easier to type (before, CustomAssert
had tried to append things to the assert
type that qunit-dom
already builds on top of qunit
), the tests seem to now finish sooner (~35 seconds before, ~23 seconds now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The demo app for
ember-container-query
shares code withembroider-css-modules
andember-workshop
. I recently updated the latter two, so it's time to update this repo's app.Notes
I couldn't convert
<Widgets::Widget-3>
to a<template>
-tag component. It would need to import<Widgets::Widget-3::TourSchedule>
in the.gts
file, but there seems to be a bug in Embroider:Maybe the combination of hyphen, followed by an ending number, causes an issue? (Renaming the folder
widget-3
towidget3
seemed to fix the build error.)