Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged embroider-css-modules and embroider-css-modules-temporary #117

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Nov 16, 2023

What changed?

Follows up on the deprecations announced in #107.

  • Removed embroider-css-modules-temporary (use embroider-css-modules instead)
  • Removed the {{local-class}} helper from ember-css-modules (use the {{local}} helper instead)

Notes

For a yet-unknown reason, the tests written in .gts-format failed in ember-canary (5.6.0-alpha.1).

CI Log
not ok 18 Chrome 118.0 - [41 ms] - Integration | Helper | local > <template> tag: returns an empty string when there are no local class names
  ---
    stack: >
      TypeError: (0 , _util.unwrapTemplate)(...).asLayout is not a function
        at new OutletComponentDefinition (http://localhost:33565/assets/vendor.js:4298:152)
        at http://localhost:33565/assets/vendor.js:5741:72
        at http://localhost:33565/assets/vendor.js:32147:37
        at track (http://localhost:33565/assets/vendor.js:40072:7)
        at valueForRef (http://localhost:33565/assets/vendor.js:32146:43)
        at Assert.evaluate (http://localhost:33565/assets/vendor.js:33825:48)
        at UpdatingVM._execute (http://localhost:33565/assets/vendor.js:37378:16)
        at http://localhost:33565/assets/vendor.js:37352:64
        at debug.runInTrackingTransaction (http://localhost:33565/assets/vendor.js:39527:21)
        at UpdatingVM.execute (http://localhost:33565/assets/vendor.js:37352:28)
    message: >
      global failure: TypeError: (0 , _util.unwrapTemplate)(...).asLayout is not a function
    negative: >
      false
    browser log: |
      {"type":"error","text":"\n\nError occurred:\n\n- While rendering:\n  -top-level\n  application\n\n"}

not ok 19 Chrome 118.0 - [60 ms] - Integration | Helper | local > <template> tag: returns a concatenated string when there are local class names
  ---
    stack: >
      TypeError: (0 , _util.unwrapTemplate)(...).asLayout is not a function
        at new OutletComponentDefinition (http://localhost:33565/assets/vendor.js:4298:152)
        at http://localhost:33565/assets/vendor.js:5741:72
        at http://localhost:33565/assets/vendor.js:32147:37
        at track (http://localhost:33565/assets/vendor.js:40072:7)
        at valueForRef (http://localhost:33565/assets/vendor.js:32146:43)
        at Assert.evaluate (http://localhost:33565/assets/vendor.js:33825:48)
        at UpdatingVM._execute (http://localhost:33565/assets/vendor.js:37378:16)
        at http://localhost:33565/assets/vendor.js:37352:64
        at debug.runInTrackingTransaction (http://localhost:33565/assets/vendor.js:39527:21)
        at UpdatingVM.execute (http://localhost:33565/assets/vendor.js:37352:28)
    message: >
      global failure: TypeError: (0 , _util.unwrapTemplate)(...).asLayout is not a function
    negative: >
      false
    browser log: |
      {"type":"error","text":"\n\nError occurred:\n\n- While rendering:\n  -top-level\n  application\n\n"}

As the failure is unlikely caused by this pull request, I'll go ahead with merging it.

@ijlee2 ijlee2 added the breaking Breaking change will result in a new major version label Nov 16, 2023
Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit 9414293
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/655611d77a057c0008e45e99
😎 Deploy Preview https://deploy-preview-117--embroider-css-modules.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ijlee2 ijlee2 marked this pull request as ready for review November 16, 2023 13:03
@ijlee2 ijlee2 merged commit 94c1417 into main Nov 16, 2023
33 of 35 checks passed
@ijlee2 ijlee2 deleted the remove-embroider-css-modules-temporary branch November 16, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change will result in a new major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant