Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port rqt controller manager to ROS 2 #1

Closed
wants to merge 25 commits into from

Conversation

ijnek
Copy link
Owner

@ijnek ijnek commented Sep 18, 2022

This is a port of rqt_controller_manager from ROS 1 to ROS 2.

  • rqt_controller_manager package
    • A port of rqt_controller_manager from ROS1, but with some modifications listed below that were necessary due to fundamental changes in the ros2 control architecture.
    • states of the controllers have changed
      • not loaded
      • unconfigured
      • inactive
      • active
      • finalized
    • the controller namespace has been replaced with controller node name
    • parameters are obtained directly from controller manager using get_parameter service rather than accessing parameter server
    • relpaces manual service calls (configure_controller, load_controller, etc.) with helper methods from controller_manager_services

ps.
The ROS1 version uses BSD. This port has modified it to Apache 2.0 because that was the only way I could get the tests passing, and it seems like everything else has been changed to apache 2.0 during hte ROS2 port.

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
…ervice clients

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
…o controller_manager.py

Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
@ijnek
Copy link
Owner Author

ijnek commented Sep 19, 2022

Closing, and reopening PR against upstream.

@ijnek ijnek closed this Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant