Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to disable automatic ROS installation #38

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Add option to disable automatic ROS installation #38

merged 3 commits into from
Nov 7, 2024

Conversation

lreiher
Copy link
Member

@lreiher lreiher commented Nov 5, 2024 •
edited
Loading

Adds new configuration option to disable automatic ROS installation

DISABLE_ROS_INSTALLATION`: 'false' # Disable automatic installation of `ros-$ROS_DISTRO-ros-core` package, e.g., if ROS is already installed in `base-image` and package is not available for the OS

lreiher
lreiher commented Nov 5, 2024
View reviewed changes
docker/Dockerfile Outdated Show resolved Hide resolved
@lreiher lreiher requested a review from jpbusch November 6, 2024 23:25
@lreiher lreiher marked this pull request as ready for review November 7, 2024 11:19
@lreiher lreiher merged commit 3d97668 into main Nov 7, 2024
6 checks passed
@lreiher lreiher deleted the option-to-disable-ros-install branch November 7, 2024 17:15
lreiher added a commit that referenced this pull request Nov 14, 2024
@lreiher
fix bug in rmw_zenoh_cpp build on Ubuntu 22
be80140 
introduced in #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbusch jpbusch jpbusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lreiher @jpbusch