Address remaining pylint complaints #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Nov 3, 2024
| @@ -323,7 +323,7 @@ def start(self): | |||
| and os.name != "nt" | |||
| ): | |||
| logger.debug("Setting child watcher") | |||
| watcher = asyncio.SafeChildWatcher() | |||
| watcher = asyncio.SafeChildWatcher() # pylint: disable=deprecated-class | |||
There was a problem hiding this comment.
Probably delete this once support for Python 3.11 and older is dropped
|
Yeah I know I know. I have little time these days, unfortunately, but will try to address such maintenance issues son. Thanks for doing a stellar job! |
ikalchev
added a commit
that referenced
this pull request
Nov 3, 2024
* Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag * Increase idle connection check interval to 300s (#475) This check was creating a lot of TimerHandles when the user had multiple bridges. We do not need to check very often as connections usually stay around for 24+hours * Implement zerocopy writes for the encrypted protocol (#476) * Implement zerocopy writes for the encrypted protocol With Python 3.12+ and later `transport.writelines` is implemented as [`sendmsg(..., IOV_MAX)`](python/cpython#91166) which allows us to avoid joining the bytes and sending them in one go. Older Python will effectively do the same thing we do now `b"".join(...)` * update tests * Revert "Late-import base36 and QR code libraries; remove SUPPORT_QR_CODE flag" (#477) * Avoid os.chmod failing on Windows if file non-existant (#471) * Avoid os.chmod failing on Windows if file non-existant * Update accessory_driver.py --------- Co-authored-by: Ivan Kalchev <25887324+ikalchev@users.noreply.github.com> * Fix mdns tests (#478) * Fix pylint complaints (#480) * Address remaining pylint complaints (#481) * Address remaining pylint complaints * Address remaining pylint complaints * v4.9.2 --------- Co-authored-by: Aarni Koskela <akx@iki.fi> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Perry Kundert <perry@kundert.ca> Co-authored-by: Ivan Kalchev <ii.kalchev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that CI will still fail because codecov now requires an upload token. We end up hard coding them in
.codecov.ymlfor most repos now ex https://github.com/aio-libs/yarl/blob/dfc41dbfcd5a91283ab6c5c21d70bc4b1c377789/.codecov.yml#L10