Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 动漫详情页根据剧集序号的表格需要进行排序 #135

Closed
2 tasks done
chivehao opened this issue Dec 5, 2022 · 2 comments · Fixed by #149
Closed
2 tasks done

[Bug] 动漫详情页根据剧集序号的表格需要进行排序 #135

chivehao opened this issue Dec 5, 2022 · 2 comments · Fixed by #149
Labels
bug Something isn't working
Milestone
0.1.0

Comments

@chivehao
Copy link
Member

chivehao commented Dec 5, 2022 •
edited
Loading

Search before asking

  • 我已经在 issues 列表 里查询过，并且没找到类似的问题。

Ikaros Component

前端后台组件 (li-guohao/ikaros-admin)

What happened

动漫详情页表格剧集顺序是乱的，需要进行排序
image

Are you willing to submit PR?

  • 是的我想要提交个PR!
@chivehao chivehao added the bug Something isn't working label Dec 5, 2022
@chivehao chivehao moved this to 🆕 New in Ikaros Project Dec 5, 2022
@chivehao chivehao added this to the 0.1.0 milestone Dec 5, 2022
@chivehao chivehao moved this from 🆕 New to 🔖 Ready in Ikaros Project Dec 5, 2022
@chivehao chivehao changed the title [Bug] 动漫详情页根据聚集序号的表格需要进行排序 [Bug] 动漫详情页根据剧集序号的表格需要进行排序 Dec 5, 2022
@chivehao
Copy link
Member Author

chivehao commented Dec 5, 2022

改进思路：

  • 服务端：季度返回剧集列表时根据剧集序号从小到大排序
  • 客户端：表格根据剧集序号从小到大排序

@chivehao chivehao linked a pull request Dec 7, 2022 that will close this issue
135 bug episode order #149
Merged
2 tasks
@chivehao
Copy link
Member Author

chivehao commented Dec 7, 2022

改进思路：

  • 服务端：季度返回剧集列表时根据剧集序号从小到大排序
  • 客户端：表格根据剧集序号从小到大排序

此问题解决：服务端给方法的结果集合添加排序

chivehao added a commit that referenced this issue Dec 7, 2022
@chivehao
135 bug episode order (#149), close issue #135
9896714 
* add sort by seq in EpisodeService#findBySeasonId

* update admin page

* update changelog for bug pr #149
Repository owner moved this from 🔖 Ready to ✅ Done in Ikaros Project Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Ikaros Project
Status: ✅ Done
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

135-bug-episode-order ikaros-dev/ikaros
135 bug episode order
1 participant
@chivehao