Added dependencies for snappdf #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per discussion: puppeteer/puppeteer#290 snappdf needs to use headless chrome which has dependencies not satisfied in the current build.
|
Thanks for your work on this. Great intention, but it looks like you've opened your pull request against your own I'm not sure when I'll rebuild (soon hopefully), but I'll definitely merge your changes. I might tweak it a little as a number of the packages you've added are already included (thus redundant). I might also add the simple PDF generation test (as noted by IN dev on your forums thread) to the build code (so build will fail if pdf generation doesn't work). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion:
puppeteer/puppeteer#290
snappdf needs to use headless chrome which has dependencies not satisfied in the current build.