Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation for copy, cut and paste #207

Merged
merged 18 commits into from
Dec 1, 2022

Conversation

RobertGrancsa
Copy link
Contributor

@RobertGrancsa RobertGrancsa commented Nov 24, 2022

Using the usual ctrl+c, ctrl+x, ctrl+v, you can copy, cut and paste the new lines.

  • I implemented a character buffer that copies the line into every time you press copy or cut, and can paste it anywhere in the file
  • I reused the implementation of duplicate, and now duplicate is just a combination of the copy and paste methods, so as to reduce the number of duplicate lines.
  • I updated the README.md to reflect these changes.

Some other clippy issues were found, regarding some borrowing and some casting, which now should be solved.

This closes #22

Signed-off-by: Robert Grancsa robert.grancsa2002@gmail.com

RobertGrancsa and others added 13 commits November 18, 2022 15:53
Signed-off-by: Robert Grancsa <robiku1975@gmail.com>
Signed-off-by: Robert Grancsa <robiku1975@gmail.com>
Signed-off-by: Robert Grancsa <robiku1975@gmail.com>
…commands

Signed-off-by: Robert Grancsa <robiku1975@gmail.com>
Signed-off-by: Robert Grancsa <robiku1975@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 42.71% // Head: 42.15% // Decreases project coverage by -0.55% ⚠️

Coverage data is based on head (2169ab2) compared to base (4dd0962).
Patch coverage: 11.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   42.71%   42.15%   -0.56%     
==========================================
  Files          10       10              
  Lines         913      918       +5     
==========================================
- Hits          390      387       -3     
- Misses        523      531       +8     
Flag Coverage Δ
x86_64-apple-darwin 42.15% <11.53%> (-0.56%) ⬇️
x86_64-unknown-linux-gnu 42.04% <11.53%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/editor.rs 27.61% <11.53%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@ilai-deutel ilai-deutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much for your contribution!

src/editor.rs Outdated Show resolved Hide resolved
src/editor.rs Outdated Show resolved Hide resolved
@ilai-deutel
Copy link
Owner

@all-contributors please add @RobertGrancsa for code

@allcontributors
Copy link
Contributor

@ilai-deutel

I've put up a pull request to add @RobertGrancsa! 🎉

Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
Signed-off-by: Robert Grancsa <robert.grancsa2002@gmail.com>
@ilai-deutel
Copy link
Owner

Thanks!

@ilai-deutel ilai-deutel merged commit 4f292f9 into ilai-deutel:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut / paste lines
2 participants