Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support specifying the visual studio version #52

Merged
merged 2 commits into from
Aug 28, 2022

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Dec 6, 2021

No description provided.

@aminya aminya force-pushed the vs-version branch 3 times, most recently from 37741f2 to 0b94b8d Compare December 6, 2021 12:50
@madebr
Copy link

madebr commented Jun 14, 2022

EDIT: It worked just fine. The windows-latest image does not have Visual Studio 2019 available, windows-2019 has.

I just tried adding this to my workflow:

    - uses: aminya/msvc-dev-cmd@vs-version
      if: "matrix.platform.msvc"
      with:
        arch: x64
        vsversion: "2019"

But it failed with the following message:

Run aminya/msvc-dev-cmd@vs-version
  with:
    arch: x64
    vsversion: 2019
Not found with vswhere
Trying standard location: C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat
Trying standard location: C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Auxiliary\Build\vcvarsall.bat
Trying standard location: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat
Trying standard location: C:\Program Files\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat
Trying standard location: C:\Program Files\Microsoft Visual Studio\2019\Professional\VC\Auxiliary\Build\vcvarsall.bat
Trying standard location: C:\Program Files\Microsoft Visual Studio\2019\Community\VC\Auxiliary\Build\vcvarsall.bat
Not found in standard locations
Not found in VS 2015 location: C:\Program Files (x86)\Microsoft Visual C++ Build Tools\vcbuildtools.bat
Error: Could not setup Developer Command Prompt: Microsoft Visual Studio not found

Using vsversion: "16.0" instead of vsversion: "2019" fails with the same message.

Copy link
Owner

@ilammy ilammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omigod, I'm sorry it took so long to merge this 🙏

@ilammy ilammy merged commit 357f053 into ilammy:master Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants