Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks file for com2ann tool #55

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

bityob
Copy link
Contributor

@bityob bityob commented Jun 27, 2023

No description provided.

@ilevkivskyi
Copy link
Owner

Thanks for the PR!

Sorry, I am not very familiar with pre-commit, can you give a bit more context on what this is doing? Will this allow other people using com2ann as a pre-commit hook?

@bityob
Copy link
Contributor Author

bityob commented Jul 12, 2023

Hey @ilevkivskyi,

Exactly, this file sets your repository as pre-commit hook for other users.

For example, in my repo I've added this configuration to the my forked repo -

# .pre-commit-config.yaml
  - repo: https://github.com/bityob/com2ann
    rev: 3bc159413799babd58eff65b258745e9ff92ad43
    hooks:
      - id: com2ann
        args: [-s]

And running pre-commit on all my files -

$ pre-commit run --all-files com2ann
com2ann..................................................................Failed
- hook id: com2ann
- files were modified by this hook

And once the files were modified and commited -

$ pre-commit run --all-files com2ann
com2ann..................................................................Passed

@ilevkivskyi ilevkivskyi merged commit 6fa4c02 into ilevkivskyi:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants