Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name the X assay "X" #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

multimeric
Copy link

@multimeric multimeric commented Mar 15, 2023

It doesn't seem to be required that all the assays are named, but I've noticed it breaks various downstream code if it is not. Most notably cbind(some_sce) will fail if not all assays are named.

@ilia-kats
Copy link
Owner

Makes sense, but an AnnData could, in principle, contain a layer named X. I would add a check if that's the case and some way to handle the collision, e.g. naming the main assay XX or main-X or something like that (also checking for collisions with the modified name)

@multimeric
Copy link
Author

I take your point, I guess that could happen, although it would be a very weird and confusing AnnData file. I'm fairly sure that Zellkonverter just gives it the name "X", but any name is better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants