Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Ember v5.9 #7888

Merged
merged 10 commits into from
Jul 16, 2024
Merged

update to Ember v5.9 #7888

merged 10 commits into from
Jul 16, 2024

Conversation

stopfstedt
Copy link
Member

No description provided.

@stopfstedt stopfstedt changed the title update ilios-common to Ember v5.9 update to Ember v5.9 Jun 14, 2024
@stopfstedt
Copy link
Member Author

stopfstedt commented Jun 17, 2024

install warnings Update: this turned out to be a non-issue, the ember-data related peer-deps warnings went away after nuking all node_modules dirs in the repo. [ST 2024/06/18]

@michaelchadwick
Copy link
Contributor

Even though it's not Ilios, I figured I'd share the notices I now get on my tutorial app, going from 5.8 to 5.9. It was successful, but I get deprecations when it builds for test:

[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')
[test:ember] DEPRECATION: The parts property on path nodes is deprecated, use head and tail instead
[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')
[test:ember] DEPRECATION: The parts property on path nodes is deprecated, use head and tail instead
[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')
[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')
[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')
[test:ember] DEPRECATION: The 'Program' visitor node is deprecated. Use 'Template' or 'Block' instead (node was 'Template')

@stopfstedt stopfstedt force-pushed the ember-cli-5.9-update branch 2 times, most recently from 4b9e349 to ddd9236 Compare June 18, 2024 19:11
@stopfstedt
Copy link
Member Author

on pnpm run start, we get a ton of these deprecation warnings.

⠇ building... [Babel: ilios-common > applyPatches]DEPRECATION: The original property on literal nodes is deprecated, use value instead
DEPRECATION: The original property on literal nodes is deprecated, use value instead
⠏ building... [Babel: ilios-common > applyPatches]DEPRECATION: The original property on literal nodes is deprecated, use value instead
DEPRECATION: The original property on literal nodes is deprecated, use value instead
...

grepping for that deprecation warning, these dependencies came up as potential emitters:

stefan@nichtsnutz: ~/dev/projects/frontend on ember-cli-5.9-update[$]
$ grep -rl 'The original property on literal nodes is deprecated, use value instead' .
./node_modules/.pnpm/prettier@3.3.2/node_modules/prettier/plugins/glimmer.js
./node_modules/.pnpm/prettier@3.3.2/node_modules/prettier/plugins/glimmer.mjs
./node_modules/.pnpm/prettier@3.3.1/node_modules/prettier/plugins/glimmer.js
./node_modules/.pnpm/prettier@3.3.1/node_modules/prettier/plugins/glimmer.mjs
./node_modules/.pnpm/@glimmer+syntax@0.92.0/node_modules/@glimmer/syntax/dist/prod/index.js
./node_modules/.pnpm/@glimmer+syntax@0.92.0/node_modules/@glimmer/syntax/dist/prod/index.js.map
./node_modules/.pnpm/@glimmer+syntax@0.92.0/node_modules/@glimmer/syntax/dist/dev/index.js
./node_modules/.pnpm/@glimmer+syntax@0.92.0/node_modules/@glimmer/syntax/dist/dev/index.cjs
./node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@babel+core@7.24.7__rsvp@4.8.5_webpack@5.92.0/node_modules/ember-source/dist/ember-template-compiler.js
./node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@babel+core@7.24.7__rsvp@4.8.5_webpack@5.92.0/node_modules/ember-source/dist/ember-template-compiler.map

@stopfstedt stopfstedt force-pushed the ember-cli-5.9-update branch 2 times, most recently from 7d08977 to 7bdc717 Compare June 20, 2024 17:14
@stopfstedt stopfstedt marked this pull request as ready for review July 5, 2024 17:21
@stopfstedt stopfstedt force-pushed the ember-cli-5.9-update branch 5 times, most recently from e5a360a to d472b30 Compare July 12, 2024 16:30
@stopfstedt stopfstedt force-pushed the ember-cli-5.9-update branch 2 times, most recently from 1a85fbd to d66f32d Compare July 15, 2024 19:42
@jrjohnson
Copy link
Member

With the release of @embroider/compat 3.5.7 the deprecation warnings should be history. This should be ready for a rebase and new lock file now and hopefully the warnings are gone. I also just merged #7969 which should clean up issues with pnpm peer dependencies.

packages/test-app/package.json Outdated Show resolved Hide resolved
we don't directly use concurrently in scripts anymore, pnpm runs things
in parallel for us now.
@jrjohnson jrjohnson enabled auto-merge July 16, 2024 21:44
@jrjohnson jrjohnson merged commit ea94b7a into ilios:master Jul 16, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants