Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow HTML Editor to grow to take up remaining space #7921

Merged
merged 1 commit into from
Jul 3, 2024
Merged

allow HTML Editor to grow to take up remaining space #7921

merged 1 commit into from
Jul 3, 2024

Conversation

michaelchadwick
Copy link
Contributor

@michaelchadwick michaelchadwick changed the title allow editor flex item to grow to take up remaining space allow HTML Editor to grow to take up remaining space Jul 2, 2024
stopfstedt
stopfstedt approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code reviewed and viz reviewed wherever we embed the WYSIWYG editor. LGTM.

@stopfstedt
Copy link
Member

@dartajax please give this another look-over. anywhere we have Froala on the screen. thanks.

@dartajax dartajax self-requested a review July 3, 2024 19:15
@dartajax
Copy link
Member

dartajax commented Jul 3, 2024

In testing the PR, I found that with this new wider format, the line returns are being reflected as they should - see below

image

@dartajax
Copy link
Member

dartajax commented Jul 3, 2024

This is on demo ...

image

dartajax
dartajax approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@dartajax dartajax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. I found some unrelated fixes that were pushed out in the recent froala upgrade while testing this PR. All good - gonna merge soon and reference the froala upgrade PR in the notes.

@dartajax
Copy link
Member

dartajax commented Jul 3, 2024

here is the froala upgrade to which I was referring ...

refs# #7884

@dartajax dartajax merged commit 80996d2 into ilios:master Jul 3, 2024
27 checks passed
@michaelchadwick michaelchadwick deleted the frontend-4320-html-editor-full-space-fix branch July 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stopfstedt stopfstedt stopfstedt approved these changes

@dartajax dartajax dartajax approved these changes

@jrjohnson jrjohnson Awaiting requested review from jrjohnson jrjohnson is a code owner

Assignees

@dartajax dartajax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML Editor should take up the full space available to it
3 participants
@michaelchadwick @stopfstedt @dartajax