Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Embroider #8019

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

jrjohnson
Copy link
Member

Once more into the breach, dear friends, once more...

Once more into the breach, dear friends, once more...
Used this router when enabling embroider, but we didn't have it
installed everywhere.
@jrjohnson jrjohnson marked this pull request as ready for review July 29, 2024 23:27
Copy link
Member

@stopfstedt stopfstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most minor issue - otherwise this looks good to me. en avant!

staticHelpers: true,
staticComponents: true,
splitAtRoutes: [
//temporarily disabled route splitting for https://github.com/ilios/ilios/issues/4508
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obsolete comment, please remove.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, fixed!

@stopfstedt stopfstedt self-requested a review July 30, 2024 17:23
@dartajax dartajax enabled auto-merge July 30, 2024 20:45
@dartajax dartajax merged commit e5b9c76 into ilios:master Jul 31, 2024
51 of 52 checks passed
@jrjohnson jrjohnson deleted the enable-embroider-once-again branch July 31, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants