rm home-grown set helper, use ember-set-helper instead. #8087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
frontend_5663_set_helper
branch
from
2ba8e22
to
447f1a6
Compare
|
[moved my comments into the issue as a better place for discussion] |
|
i'm shelving this for the moment, but plan on getting back into it next week. |
stopfstedt
force-pushed
the
frontend_5663_set_helper
branch
2 times, most recently
from
d7a0b1a
to
0437c20
Compare
|
regex search/replace for the win. |
stopfstedt
added
the
ready to merge
jrjohnson
requested changes
Sep 9, 2024
stopfstedt
force-pushed
the
frontend_5663_set_helper
branch
from
92e45ad
to
f7ea5c9
Compare
jrjohnson
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ilios/ilios#5663
see 6da92ba
to check, use this grep-chain in the repo's root: