github test: use lxml==5.2 to fix jmdict test

ilius · Sep 2, 2024 · eac286b · eac286b
1 parent 1f095ad
commit eac286b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -35,7 +35,7 @@ jobs:
             beautifulsoup4 \
             biplist html5lib \
             python-idzip \
-            lxml \
+            lxml==5.2 \
             marisa-trie \
             mistune
       - name: Remove test cache

diff --git a/tests/g_jmdict_test.py b/tests/g_jmdict_test.py
@@ -23,6 +23,8 @@ def convert_jmdict_txt(self, fname, fname2, **convertArgs):
 			**convertArgs,
 		)
 
+	# for some reason, with lxml==5.3.0, for "bword://{word}", `word` is not unicode-escaped by lxml
+	# while lxml < 5.3.0 does escape these unicode characters
 	def test_convert_jmdict_txt_1(self):
 		self.convert_jmdict_txt(
 			"050-JMdict-English",