Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use addEntryObj(entry: BaseEntry) instead of addEntryObj(entry: Entry) #424

Closed
EvanLuo42 opened this issue Feb 3, 2023 · 1 comment
Closed

Use addEntryObj(entry: BaseEntry) instead of addEntryObj(entry: Entry) #424

EvanLuo42 opened this issue Feb 3, 2023 · 1 comment
Labels
Bug

Comments

@EvanLuo42
Copy link

If you use Entry, the IDE will have some warnings. (I don't know whether or not use BaseEntry will cause any issue)
ilius added a commit that referenced this issue Feb 3, 2023
@ilius
fix type for Glossary.addEntryObj, #424
85d0aa2
ilius added a commit that referenced this issue Feb 3, 2023
@ilius
fix bug of glos.addEntryObj(dataEntry) adding empty file
fc27193 
because tmpDataDir is not set until glos.read()
set and create tmpDataDir on glos.tmpDataDir access, and add test, #424
@ilius
Copy link
Owner

ilius commented Feb 3, 2023

I also fixed a bug on adding data entry.
Thanks for report.

@ilius ilius closed this as completed Feb 3, 2023
@ilius ilius added the Bug label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilius @EvanLuo42