Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yomichan term bank numbering should start from 1, not 0 #446

Closed
StefanVukovic99 opened this issue Mar 22, 2023 · 2 comments
Closed

Yomichan term bank numbering should start from 1, not 0 #446

StefanVukovic99 opened this issue Mar 22, 2023 · 2 comments
Labels
Bug

Comments

@StefanVukovic99
Copy link

When converting to Yomichan format (from .dsl, in my case) the first term bank is term_bank_0.json, but when importing into yomichan it will ignore this file and import only term_bank_1.json and above.
ilius added a commit that referenced this issue Mar 22, 2023
@ilius
Yomichan: start with term_bank_1.json, #446
361d8c4
@ilius
Copy link
Owner

ilius commented Mar 22, 2023

Please try again.
Thanks.

@StefanVukovic99
Copy link
Author

Works great, thanks.

@ilius ilius closed this as completed Mar 22, 2023
@ilius ilius added the Bug label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilius @StefanVukovic99