Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tix dependency from ui_tk #595

Closed
shoudairika opened this issue Nov 24, 2024 · 2 comments · Fixed by #600
Closed

Remove tix dependency from ui_tk #595

shoudairika opened this issue Nov 24, 2024 · 2 comments · Fixed by #600
Labels
Improvement

Comments

@shoudairika
Copy link

tkinter.tix — Extension widgets for Tk

Source code: Lib/tkinter/tix.py

Deprecated since version 3.6: This Tk extension is unmaintained and should not be used in new code. Use tkinter.ttk instead.
@ilius
Copy link
Owner

ilius commented Nov 24, 2024

It's not a quick replacement.
As long of it works (for Windows users who don't like command line), it's fine.
But if you can fix it without breaking anything, please add a PR.

@ilius ilius closed this as completed Nov 24, 2024
@ilius ilius reopened this Dec 4, 2024
@ilius ilius changed the title tix to ttk? Remove tix dependency from ui_tk Dec 4, 2024
glowinthedark pushed a commit to glowinthedark/pyglossary that referenced this issue Dec 9, 2024
fixes ilius#595 remove tix
89d623e 
- replace tix with ttk
@glowinthedark glowinthedark mentioned this issue Dec 9, 2024
Merged
@glowinthedark
Copy link
Contributor

glowinthedark commented Dec 9, 2024 •
edited
Loading

gave it a quick try in #600 since tk UI never worked on mac, and now it does, for the first time 😄 ; sacrificed a bit on the UI, probably there are cleaner ways to do it

ilius pushed a commit that referenced this issue Dec 10, 2024
@glowinthedark
fixes #595 remove tix (#600)
479f2ef 
* fixes #595 remove tix

- replace tix with ttk

* - ruff fix

* - version tab

* - version tab alignment

* - ruff fix

* - cleanup

---------

Co-authored-by: glwnd <glwnd>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #595 remove tix glowinthedark/pyglossary
3 participants
@ilius @glowinthedark @shoudairika