Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

position prop #234

Closed
veronQ opened this issue Oct 17, 2019 · 3 comments
Closed

position prop #234

veronQ opened this issue Oct 17, 2019 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@veronQ
Copy link

veronQ commented Oct 17, 2019

Would you consider adding a new position prop to change the select position depending on the current scroll position?

Maybe something like this:

position: [ 'auto', 'above', 'below' ]

Thank your for this plugin.
@iliyaZelenko
Copy link
Owner

iliyaZelenko commented Oct 17, 2019 •
edited
Loading

@veronQ Thanks for using my plugin. It seems like 2 days ago I was asked to do something similar. Apparently this is what you need, but in your version there is still the opportunity to specify the static position above or below. I will deal with this in the near future, especially if two people need it at once.

@iliyaZelenko iliyaZelenko added the duplicate This issue or pull request already exists label Oct 17, 2019
iliyaZelenko added a commit that referenced this issue Oct 17, 2019
@iliyaZelenko
feat(menu): new props: menuDynamicPosition, menuDefaultPosition. Smar…
6a30ed3 
…t position for menu

re #228, #234
iliyaZelenko pushed a commit that referenced this issue Oct 17, 2019
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
c60e9c2 
# [3.2.0](v3.1.0...v3.2.0) (2019-10-17)

### Features

* **menu:** new props: menuDynamicPosition, menuDefaultPosition. Smart position for menu ([6a30ed3](6a30ed3)), closes [#228](#228) [#234](#234)
@iliyaZelenko
Copy link
Owner

Please, see this answer.

@veronQ
Copy link
Author

veronQ commented Oct 21, 2019 •
edited
Loading

It works like a charm!
Thank you for adding this new feature.

rin4573281133639 added a commit to rin4573281133639/iliyaZelenko9 that referenced this issue Feb 5, 2022
@rin4573281133639
chore(release): 3.2.0 [skip ci]
9f3ed71 
# [3.2.0](iliyaZelenko/vue-cool-select@v3.1.0...v3.2.0) (2019-10-17)

### Features

* **menu:** new props: menuDynamicPosition, menuDefaultPosition. Smart position for menu ([6a30ed3](iliyaZelenko/vue-cool-select@6a30ed3)), closes [#228](iliyaZelenko/vue-cool-select#228) [#234](iliyaZelenko/vue-cool-select#234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iliyaZelenko @veronQ